rohitrastogi commented on code in PR #10305:
URL: https://github.com/apache/datafusion/pull/10305#discussion_r1583965449
##########
datafusion/optimizer/src/rewrite_disjunctive_predicate.rs:
##########
@@ -239,8 +252,7 @@ fn flatten_and_predicates(
for predicate in and_predicates {
match predicate {
Predicate::And { args } => {
- flattened_predicates
-
.extend_from_slice(flatten_and_predicates(args).as_slice());
+ flattened_predicates.append(&mut flatten_and_predicates(args));
Review Comment:
Append should move the predicates instead of cloning them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
