vaibhawvipul commented on PR #335: URL: https://github.com/apache/datafusion-comet/pull/335#issuecomment-2084536168
@andygrove I have enabled a "string to timestamp" cast test case that passes. We are supporting all the timestamps mentioned in the issue. [ <img width="683" alt="Screenshot 2024-04-30 at 12 30 35 PM" src="https://github.com/apache/datafusion-comet/assets/10995936/5a55fad0-4490-437b-8945-67199a7dbe27";> ](url) Input | Spark | Comet -- | -- | -- 2020 | 2020-01-01 00:00:00.0 | 2020-01-01 00:00:00.0 2020-01 | 2020-01-01 00:00:00.0 | 2020-01-01 00:00:00.0 2020-01-01 | 2020-01-01 00:00:00.0 | 2020-01-01 00:00:00.0 2020-01-01T12 | 2020-01-01 12:00:00.0 | 2020-01-01 12:00:00.0 2020-01-01T12:34 | 2020-01-01 12:34:00.0 | 2020-01-01 12:34:00.0 2020-01-01T12:34:56 | 2020-01-01 12:34:56.0 | 2020-01-01 12:34:56.0 2020-01-01T12:34:56.123456 | 2020-01-01 12:34:56.123456 | 2020-01-01 12:34:56.123456 T2 | 2024-04-25 02:00:00.0 | 2024-04-25 02:00:00.0 Just a note - - Spark supports some additional inputs like - "213" or "85678". i.e 3 digit and 5 digit years too! This is not being supported right now by Comet in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
