dmitrybugakov commented on code in PR #10302:
URL: https://github.com/apache/datafusion/pull/10302#discussion_r1584290980
##########
datafusion/optimizer/src/eliminate_filter.rs:
##########
@@ -78,17 +56,47 @@ impl OptimizerRule for EliminateFilter {
fn apply_order(&self) -> Option<ApplyOrder> {
Some(ApplyOrder::TopDown)
}
+
+ fn supports_rewrite(&self) -> bool {
+ true
+ }
+
+ fn rewrite(
+ &self,
+ plan: LogicalPlan,
+ _config: &dyn OptimizerConfig,
Review Comment:
@Omega359 clippy was failed with
`Parameter config is only used in recursion. Consider prefixing it with an
underscore: _config.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
