alamb commented on code in PR #10260:
URL: https://github.com/apache/datafusion/pull/10260#discussion_r1584900962
##########
datafusion/core/tests/dataframe/describe.rs:
##########
@@ -81,6 +81,36 @@ async fn describe_boolean_binary() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn describe_null() -> Result<()> {
+ let ctx = parquet_context().await;
+
+ //add test case for only boolean boolean/binary column
+ let result = ctx
+ .sql("select 'a' as a, null as b")
+ .await?
+ .describe()
+ .await?
+ .collect()
+ .await?;
+ #[rustfmt::skip]
+ let expected = [
+ "+------------+------+------+",
+ "| describe | a | b |",
+ "+------------+------+------+",
+ "| count | 1 | 0 |",
+ "| null_count | 0 | 1 |",
Review Comment:
❤️ -- thank you @Weijun-H
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
