andygrove commented on code in PR #355:
URL: https://github.com/apache/datafusion-comet/pull/355#discussion_r1584982985
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2318,6 +2330,13 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde {
return None
}
+ for (key <- join.leftKeys) {
+ if (!supportedSortMergeJoinEqualType(key.dataType)) {
+ withInfo(op, s"Unsupported join key type ${key.dataType} on key:
${key.sql}")
+ return None
Review Comment:
nit: do we want to stop checking as soon as we hit one unsupported key type
or should we call `withInfo` for each unsupported key type (if there are
multiple)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
