alamb commented on PR #10309: URL: https://github.com/apache/datafusion/pull/10309#issuecomment-2088451059
> @alamb, this looks good to me. However, I'm concerned there might be redundant `LimitStream` overhead when both `GlobalLimitExec` and `StreamTableExec` are present in the plan, as `LimitStream` appears to be used twice. > > Additionally, it would be better to use unit tests addition to `slt` tests, given that `GlobalLimitExec` already ensures the tests function properly even if `StreamTableExec` fails. Those are excellent points. @lewiszlw are you able to add the unit tests? Otherwise I can try and find some time to do so -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
