alamb commented on code in PR #10325:
URL: https://github.com/apache/datafusion/pull/10325#discussion_r1587482704
##########
datafusion/expr/src/expr.rs:
##########
@@ -399,18 +399,11 @@ impl Between {
}
}
-#[derive(Debug, Clone, PartialEq, Eq, Hash)]
-/// Defines which implementation of a function for DataFusion to call.
-pub enum ScalarFunctionDefinition {
- /// Resolved to a user defined function
- UDF(Arc<crate::ScalarUDF>),
-}
-
/// ScalarFunction expression invokes a built-in scalar function
#[derive(Clone, PartialEq, Eq, Hash, Debug)]
pub struct ScalarFunction {
/// The function
- pub func_def: ScalarFunctionDefinition,
+ pub func_def: Arc<crate::ScalarUDF>,
Review Comment:
If we are changing the API, do we want to change this to `func` too while we
are at it?
(I think this is what @jayzhan211 is saying in
https://github.com/apache/datafusion/pull/10325#discussion_r1587001540)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
