alamb commented on code in PR #10356:
URL: https://github.com/apache/datafusion/pull/10356#discussion_r1588237252
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -467,6 +468,200 @@ impl LogicalPlan {
self.with_new_exprs(self.expressions(), inputs.to_vec())
}
+ /// Recomputes schema and type information for this LogicalPlan if needed.
Review Comment:
I believe this is a new API for using `TreeNode` to rewrite plans in ways
that change the schema.
This effectively factors out the recalculation part of
`LogicalPlan::new_with_exprs`
I tried to find a way to use reuse this logic in
`LogicalPlan::new_with_exprs` but was not able to without forcing (another)
clone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
