planga82 commented on code in PR #365: URL: https://github.com/apache/datafusion-comet/pull/365#discussion_r1588316130
########## common/src/main/scala/org/apache/comet/CometConf.scala: ########## @@ -383,6 +383,13 @@ object CometConf { .booleanConf .createWithDefault(false) + val COMET_SORTMERGEJOIN_CHECK_KEY_TYPES: ConfigEntry[Boolean] = Review Comment: I think it's not the same idea and not applicable here. I'll close this PR and try to think of another way to do it without adding configuration. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org