andygrove commented on code in PR #362:
URL: https://github.com/apache/datafusion-comet/pull/362#discussion_r1588329000
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -825,19 +839,26 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
private def castTest(input: DataFrame, toType: DataType): Unit = {
+
+ // we do not support the TryCast expression in Spark 3.2 and 3.3
+ // https://github.com/apache/datafusion-comet/issues/374
+ val testTryCast = CometSparkSessionExtensions.isSpark34Plus
+
withTempPath { dir =>
val data = roundtripParquet(input, dir).coalesce(1)
data.createOrReplaceTempView("t")
withSQLConf((SQLConf.ANSI_ENABLED.key, "false")) {
// cast() should return null for invalid inputs when ansi mode is
disabled
val df = spark.sql(s"select a, cast(a as ${toType.sql}) from t order
by a")
- checkSparkAnswer(df)
+ checkSparkAnswerAndOperator(df)
Review Comment:
We need this so that we make sure that the comet plan really ran with comet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
