yyy1000 commented on issue #10256:
URL: https://github.com/apache/datafusion/issues/10256#issuecomment-2092214756
Good, I can try to implement it. :)
Another concern for me is changing the function signature to `pub fn
expr_to_sql(expr: &Expr) -> Result<Unparsed>` would lead every call of
`expr_to_sql` a convert to ast::Expr in the original code, would this be a good
choice? 🤔
For example, There would be something like
```
let l = self.expr_to_sql(left.as_ref())?;
let expr = match l {
Unparsed::Expr(expr) => expr,
Unparsed::OrderByExpr(_) => internal_err(),
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
