alamb opened a new issue, #10365: URL: https://github.com/apache/datafusion/issues/10365
### Is your feature request related to a problem or challenge? Part of https://github.com/apache/datafusion/issues/10210 we are trying to make the optimizer faster by making the different optimizer passes faster. https://github.com/apache/datafusion/pull/10356 avoids a bunch of copies in the TypeCoercion pass @peter-toth pointed out https://github.com/apache/datafusion/pull/10356/files#r1588892502 that this pass still does more work than necessary as it still always recomputes the schema, even when it didn't make any changes The root cause for this is that the expression rewrite that happens via `TypeCoercionRewriter` doesn't return `Transformed` and thus we must conservatively assume that the schema needs to be recomputed ### Describe the solution you'd like 1. Change `TypeCoercionRewriter` to return Transformed somehow 2. Only call `LogicalPlan::recompute_schema` when the expression is actually transformed ### Describe alternatives you've considered _No response_ ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
