alamb commented on code in PR #10367:
URL: https://github.com/apache/datafusion/pull/10367#discussion_r1589222401
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -1864,7 +1864,7 @@ impl SessionState {
// analyze & capture output of each rule
let analyzer_result = self.analyzer.execute_and_check(
- e.plan.as_ref(),
+ e.plan.as_ref().clone(),
Review Comment:
This is where the cloning happens now (at the callsite)
##########
datafusion/optimizer/src/analyzer/mod.rs:
##########
@@ -115,7 +115,7 @@ impl Analyzer {
/// do necessary check and fail the invalid plans
pub fn execute_and_check<F>(
&self,
- plan: &LogicalPlan,
+ plan: LogicalPlan,
Review Comment:
This is the API change and the clone is removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
