andygrove commented on code in PR #362: URL: https://github.com/apache/datafusion-comet/pull/362#discussion_r1589303225
########## spark/src/test/scala/org/apache/comet/CometCastSuite.scala: ########## @@ -65,29 +67,12 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper { } else if (!testExists) { fail(s"Missing test: $expectedTestName") } - } else if (testExists) { - fail(s"Found test for cast that Spark does not support: $expectedTestName") Review Comment: Not yet, but it would fail once we add tests for casting to/from TimestampNTZType because Spark 3.2 doesn't have that one. This change is unrelated to this PR though, so happy to remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org