andygrove commented on code in PR #340:
URL: https://github.com/apache/datafusion-comet/pull/340#discussion_r1589576324
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -665,6 +665,30 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
castTest(generateTimestamps(), DataTypes.DateType)
}
+ test("cast short to byte") {
Review Comment:
These methods already exist in main but have different naming, so I think
you need to upmerge/rebase against main.
Example:
```
ignore("cast ShortType to ByteType")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
