yyy1000 commented on code in PR #10370:
URL: https://github.com/apache/datafusion/pull/10370#discussion_r1589814242
##########
datafusion/sql/src/unparser/expr.rs:
##########
@@ -305,10 +352,10 @@ impl Unparser<'_> {
})
}
Expr::Sort(Sort {
- expr,
+ expr: _,
asc: _,
nulls_first: _,
- }) => self.expr_to_sql(expr),
+ }) => internal_err!("Sort expression should be handled by
expr_to_unparsed"),
Review Comment:
Ohh, great. Now I know better when to use these types of error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
