jayzhan211 opened a new issue, #10373:
URL: https://github.com/apache/datafusion/issues/10373

   ### Is your feature request related to a problem or challenge?
   
   While working on #10364, I found that changing the result in the rust test 
is quite painful.
   
   Currently, we need to fix the string manually one by one
   
   ```
   let expected = [
           "+---------------+",
           "| upper(test.a) |",
           "+---------------+",
           "| ABCDEF        |",
           "| ABC123        |",
           "| CBADEF        |",
           "| 123ABCDEF     |",
           "+---------------+",
       ];
       assert_fn_batches!(expr, expected);
   ```
   
   It would be nice if we have `sqllogictest` like testing for `dataframe` or 
`expr` API , so we can update the result with `--complete` very easily.
   
   ### Describe the solution you'd like
   
   Given the test, having a very easy way to auto-update result string
   
   ```rust
   #[tokio::test]
   async fn test_fn_upper() -> Result<()> {
       let expr = upper(col("a"));
   
       let expected = [
           "+---------------+",
           "| upper(test.a) |",
           "+---------------+",
           "| ABCDEF        |",
           "| ABC123        |",
           "| CBADEF        |",
           "| 123ABCDEF     |",
           "+---------------+",
       ];
       assert_fn_batches!(expr, expected);
   
       Ok(())
   }
   ```
   
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to