prashantksharma commented on issue #361: URL: https://github.com/apache/datafusion-comet/issues/361#issuecomment-2094060848
@andygrove , cc: @viirya ## Minor Query before opening PR <ins>Summary</ins>: - Have made changes to `expr.proto` and `QueryPlanSerde.scala`. The changes have been pushed to a separate branch on my fork. The comparison can be seen [here](https://github.com/apache/datafusion-comet/compare/main...prashantksharma:datafusion-comet:issue-361-enum-for-eval_mode): - `make test-rust` gives following error.  <ins>Minor Query</ins>: Before opening the PR, I wanted to confirm, if I should go ahead and resolve the error for `planner.rs` or a separate issue needs to be created for this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
