andygrove commented on code in PR #379:
URL: https://github.com/apache/datafusion-comet/pull/379#discussion_r1590008164
##########
spark/src/main/scala/org/apache/comet/GenerateDocs.scala:
##########
@@ -64,23 +64,36 @@ object GenerateDocs {
val outputFilename = "docs/source/user-guide/compatibility.md"
val w = new BufferedOutputStream(new FileOutputStream(outputFilename))
for (line <- Source.fromFile(templateFilename).getLines()) {
- if (line.trim == "<!--CAST_TABLE-->") {
- w.write("| From Type | To Type | Compatible? | Notes |\n".getBytes)
- w.write("|-|-|-|-|\n".getBytes)
+ if (line.trim == "<!--COMPAT_CAST_TABLE-->") {
Review Comment:
There was previously one table, but now we show separate tables for
compatible and incompatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
