jayzhan211 commented on PR #10372: URL: https://github.com/apache/datafusion/pull/10372#issuecomment-2094844030
> Thank you @jayzhan211 > > This looks great and I think it is a nice verification that we can extract aggregates from the code. I left some small suggestions but I don't think they are necessary -- I also updated the title and description of this PR to be more description > > I believe this function (and related ones) are part of what @yyy1000 was working on when we started down the path to extract this type of thing from the core. I plan to work on Sum or others that have additional features, but not too complex ones. `covar_pop` can be a good first issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
