viirya commented on code in PR #380:
URL: https://github.com/apache/datafusion-comet/pull/380#discussion_r1591067783
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -916,7 +916,10 @@ object CometSparkSessionExtensions extends Logging {
private[comet] def isCometShuffleEnabled(conf: SQLConf): Boolean =
COMET_EXEC_SHUFFLE_ENABLED.get(conf) &&
(conf.contains("spark.shuffle.manager") &&
conf.getConfString("spark.shuffle.manager") ==
- "org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager")
+ "org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager") &&
+ // TODO: AQE coalesce partitions feature causes Comet shuffle memory
leak.
Review Comment:
As I mentioned in the ticket, when coalesce partitions is enabled, Spark
will combine the partitions of multiple reducers. I suspect that causes
incorrect format to read for Java Arrow StreamReader.
We should address this issue further to unblock Comet shuffle with coalesce
partitions. But for now, I think it is better to disable it temporarily for the
cases we know it will cause some issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
