peter-toth commented on PR #10396: URL: https://github.com/apache/datafusion/pull/10396#issuecomment-2099122187
I think if this PR can be merged then IMO the next steps should be: 1. Fix https://github.com/apache/datafusion/issues/10413 as that is correctness bug 2. Continue https://github.com/apache/datafusion/pull/10067 efforts to refactor the rule `CommonSubexprEliminate` to `rewrite` as that could improve a lot on https://github.com/apache/datafusion/issues/9873 3. Rebase @MohamedAbdeen21's https://github.com/apache/datafusion/pull/10333 on the top of this PR as probably we don't need to use the current string identifiers in aliases and we could improve readablity. 4. Revisit the identifier issue as using these string identifiers as the keys of `ExprStats` was not the best choice. See my comment on this in the PR description. I'm happy to take 4 as I already worked on it a bit, but unfortunately I have very little time to work on this project lately so I can't take 1. and 2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
