parthchandra commented on code in PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#discussion_r1592975258
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -734,6 +734,22 @@ class CometSparkSessionExtensions
} else {
var newPlan = transform(plan)
+ // if the plan cannot be run natively then explain why (when
appropriate config is enabled)
Review Comment:
Given that ExecRule is going to be invoked multiple times as planning
proceeds, this may get logged multiple times for the same plan. Perhaps that is
why we need to keep this configurable.
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -276,6 +276,14 @@ object CometConf {
.booleanConf
.createWithDefault(false)
+ val COMET_EXPLAIN_FALLBACK_ENABLED: ConfigEntry[Boolean] =
Review Comment:
Do we really need to make this configurable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
