andygrove commented on code in PR #396:
URL: https://github.com/apache/datafusion-comet/pull/396#discussion_r1593206071
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -867,26 +867,27 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
- private def castFallbackTestTimezone(
- input: DataFrame,
- toType: DataType,
- expectedMessage: String): Unit = {
- withTempPath { dir =>
- val data = roundtripParquet(input, dir).coalesce(1)
- data.createOrReplaceTempView("t")
-
- withSQLConf(
- (SQLConf.ANSI_ENABLED.key, "false"),
- (CometConf.COMET_CAST_ALLOW_INCOMPATIBLE.key, "true"),
- (SQLConf.SESSION_LOCAL_TIMEZONE.key, "America/Los_Angeles")) {
- val df = data.withColumn("converted", col("a").cast(toType))
- df.collect()
- val str =
- new
ExtendedExplainInfo().generateExtendedInfo(df.queryExecution.executedPlan)
- assert(str.contains(expectedMessage))
- }
- }
- }
+ // TODO Commented out to work around scalafix since this is currently unused.
Review Comment:
Thank you. I will see if this is still needed and follow up to use or remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
