andygrove commented on code in PR #399:
URL: https://github.com/apache/datafusion-comet/pull/399#discussion_r1593256620
##########
core/src/execution/datafusion/expressions/cast.rs:
##########
@@ -232,6 +232,189 @@ macro_rules! cast_int_to_int_macro {
}};
}
+// When Spark casts to Byte/Short Types, it does not cast directly to
Byte/Short.
Review Comment:
My preference is for keeping the code as simple as possible to make it easy
for others to contribute. I think having two similar macros is fine here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
