phillipleblanc commented on code in PR #10419:
URL: https://github.com/apache/datafusion/pull/10419#discussion_r1593494268
##########
datafusion/core/src/datasource/listing/url.rs:
##########
@@ -187,7 +187,10 @@ impl ListingTableUrl {
/// Returns `true` if `path` refers to a collection of objects
pub fn is_collection(&self) -> bool {
- self.url.as_str().ends_with(DELIMITER)
+ let mut url = self.url.clone();
+ url.set_query(None);
+ url.set_fragment(None);
+ url.as_str().ends_with(DELIMITER)
Review Comment:
```suggestion
url.path().ends_with(DELIMITER)
```
I tested that this should work, and it avoids a clone of the URL:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=c574fe5ec9fc2a45e33667a2907867f6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
