comphead commented on code in PR #10420:
URL: https://github.com/apache/datafusion/pull/10420#discussion_r1594238729
##########
datafusion/core/src/catalog/information_schema.rs:
##########
@@ -225,37 +213,29 @@ impl InformationSchemaConfig {
#[async_trait]
impl SchemaProvider for InformationSchemaProvider {
- fn as_any(&self) -> &(dyn Any + 'static) {
+ fn as_any(&self) -> &dyn Any {
self
}
fn table_names(&self) -> Vec<String> {
- vec![
- TABLES.to_string(),
- VIEWS.to_string(),
- COLUMNS.to_string(),
- DF_SETTINGS.to_string(),
- SCHEMATA.to_string(),
- ]
+ INFORMATION_SCHEMA_TABLES
+ .iter()
+ .map(|t| t.to_string())
+ .collect()
}
async fn table(
&self,
name: &str,
) -> Result<Option<Arc<dyn TableProvider>>, DataFusionError> {
Review Comment:
Not related to this PR but do we need Result in return 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
