andygrove opened a new issue, #402:
URL: https://github.com/apache/datafusion-comet/issues/402

   ### What is the problem the feature request solves?
   
   In `CometCastSuite` we have a shared method `castTest` which executes 
queries against Spark and Comet and compares results.
   
   In the case where we expect the cast to fail, we compare error messages.
   
   When running against Spark 3.4 we expect the error messages to be identical, 
but for 3.2 and 3.3 we have been adding custom handling for different types of 
errors, and this area of code is becoming a bit hacky (my bad) and I think we 
need a better mechanism.
   
   I propose adding a capability for individual tests to provide their own 
lambda functions for checking for expected errors. I plan on creating a PR with 
a proposal.
   
   ### Describe the potential solution
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to