alamb opened a new pull request, #10430: URL: https://github.com/apache/datafusion/pull/10430
Draft as it builds on https://github.com/apache/datafusion/pull/10427 ## Which issue does this PR close? Part of https://github.com/apache/datafusion/issues/10287 ## Rationale for this change I am trying to avoid copying as much in `EliminateCrossJoin` to speed up planning. One thing this rule does is quite a few `Expr` copies while checking exprs for join keys ## What changes are included in this PR? 1. Move management of join key exprs to `JoinExprSet` struct 2. Reduce copying of clones internally to `JoinExprSet` 3. New tests for `JoinExprSet` ## Are these changes tested? Existing CI ## Are there any user-facing changes? No functional changes Performance tests (running) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
