alamb commented on code in PR #10446:
URL: https://github.com/apache/datafusion/pull/10446#discussion_r1596956807
##########
datafusion/expr/src/utils.rs:
##########
@@ -1107,20 +1107,49 @@ fn split_binary_impl<'a>(
/// assert_eq!(conjunction(split), Some(expr));
/// ```
pub fn conjunction(filters: impl IntoIterator<Item = Expr>) -> Option<Expr> {
- filters.into_iter().reduce(|accum, expr| accum.and(expr))
+ filters.into_iter().reduce(Expr::and)
Review Comment:
this is the very minor simplification and while I was in here I figured I
would improve the docs too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
