jonahgao commented on code in PR #10459:
URL: https://github.com/apache/datafusion/pull/10459#discussion_r1597639097


##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -210,7 +210,6 @@ async fn test_count_wildcard_on_aggregate() -> Result<()> {
     let sql_results = ctx
         .sql("select count(*) from t1")
         .await?
-        .select(vec![count(wildcard())])?

Review Comment:
   Projecting an aggregation expression not by column reference on top of a 
Projection plan should be invalid in SQL.
   I'm not sure whether DataFrame needs it, if necessary, we can expand 
LogicalPlan:: columnized_output_exprs to support input being Projection.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to