alamb commented on issue #10295: URL: https://github.com/apache/datafusion/issues/10295#issuecomment-2107386884
I took a quick look at https://github.com/apache/datafusion/blob/58cc4e1289451b30adca4721fd6eb5a36b26a2cd/datafusion/optimizer/src/single_distinct_to_groupby.rs#L59 Looks to me like there are basically 2 things to do: 1. Switch to use `OptimizerRule::rewrite` API (as in https://github.com/apache/datafusion/pull/10166) 2. Remove the `expr.clone()` calls here https://github.com/apache/datafusion/blob/58cc4e1289451b30adca4721fd6eb5a36b26a2cd/datafusion/optimizer/src/single_distinct_to_groupby.rs#L131 Once you do 1. 2 should be pretty simple (maybe even just remove the `.clone()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
