ozankabak commented on code in PR #10483:
URL: https://github.com/apache/datafusion/pull/10483#discussion_r1598371311
##########
datafusion/sql/src/parser.rs:
##########
@@ -462,7 +462,18 @@ impl<'a> DFParser<'a> {
pub fn parse_option_key(&mut self) -> Result<String, ParserError> {
let next_token = self.parser.next_token();
match next_token.token {
- Token::Word(Word { value, .. }) => Ok(value),
+ Token::Word(Word { value, .. }) => {
+ let mut parts = vec![value];
+ while self.parser.consume_token(&Token::Period) {
+ let next_token = self.parser.next_token();
+ if let Token::Word(Word { value, .. }) = next_token.token {
+ parts.push(value);
+ } else {
+ return self.parser.expected("key name", next_token);
+ }
+ }
+ Ok(parts.join("."))
+ }
Review Comment:
This is the main change, the rest is clean-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
