jayzhan211 commented on code in PR #10469: URL: https://github.com/apache/datafusion/pull/10469#discussion_r1598379495
########## datafusion/proto/tests/cases/roundtrip_logical_plan.rs: ########## @@ -581,7 +581,7 @@ async fn roundtrip_expr_api() -> Result<()> { make_array(vec![lit(1), lit(2), lit(3)]), lit(1), lit(2), - lit(1), + Some(lit(1)), Review Comment: Maybe add the example that has None for stride? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org