advancedxy commented on code in PR #424:
URL: https://github.com/apache/datafusion-comet/pull/424#discussion_r1600023085
##########
core/src/execution/datafusion/spark_hash.rs:
##########
@@ -218,6 +263,34 @@ fn create_hashes_dictionary<K: ArrowDictionaryKeyType>(
Ok(())
}
+fn create_xxhash64_hashes_dictionary<K: ArrowDictionaryKeyType>(
Review Comment:
This is mostly copied and pasted from `create_hashes_dictionary`, maybe we
should rewrite it with macros?
##########
core/src/execution/datafusion/spark_hash.rs:
##########
@@ -347,6 +513,213 @@ pub fn create_hashes<'a>(
Ok(hashes_buffer)
}
+pub fn create_xxhash64_hashes<'a>(
+ arrays: &[ArrayRef],
+ hashes_buffer: &'a mut [u64],
Review Comment:
It's similar as `create_hashes` as well.
I'm not sure how to define a generic method that take both `&'a mut [u32]`
and `&'a mut [u64]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
