andygrove commented on code in PR #694: URL: https://github.com/apache/datafusion-python/pull/694#discussion_r1600115361
########## Cargo.toml: ########## @@ -60,7 +60,7 @@ url = "2.2" pyo3-build-config = "0.20.0" [lib] -name = "datafusion_python" Review Comment: Does this have any impact on downstream maturin projects that use this crate as a dependency? If they also use the name `_internal`, will there be a conflict? Should we replace all references to `_internal` with `datafusion_internal` instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
