viirya commented on code in PR #10495:
URL: https://github.com/apache/datafusion/pull/10495#discussion_r1600243749


##########
datafusion/core/tests/sql/joins.rs:
##########
@@ -231,3 +231,32 @@ async fn join_change_in_planner_without_sort_not_allowed() 
-> Result<()> {
     }
     Ok(())
 }
+
+#[tokio::test]
+async fn test_smj_with_join_filter_fitering_all() -> Result<()> {
+    let ctx: SessionContext = SessionContext::new();
+
+    let sql = "set datafusion.optimizer.prefer_hash_join = false;";
+    let _ = ctx.sql(sql).await?.collect().await?;
+
+    let sql = "set datafusion.execution.batch_size = 1";
+    let _ = ctx.sql(sql).await?.collect().await?;
+
+    let sql = "

Review Comment:
   No, I simply copy the reproducer from the issue. Let me move it to 
sort_merge_join.slt.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to