viirya commented on code in PR #425: URL: https://github.com/apache/datafusion-comet/pull/425#discussion_r1600538355
########## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ########## @@ -1467,4 +1467,23 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper { } } + test("unbase64") { + withTable("t1", "t2") { + sql("create table t1(col string) using parquet") + sql("""INSERT INTO t1 VALUES + |('537061726B2053514C'), + |('737472696E67'), + |('\\0'), + |(''), + |('###'), + |('G123'), + |('hello'), + |('A1B'), + |('0A1B')""".stripMargin) + sql("create table t2(col string) using parquet") + sql("insert into t2 select base64(col) from t1") + + checkSparkAnswerAndOperator("SELECT unbase64(col) FROM t2") Review Comment: Why we need to insert `base64(col)` into `t2` before comparing? Cannot we just check the results of `select base64(col) from t1`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org