alamb commented on code in PR #10392:
URL: https://github.com/apache/datafusion/pull/10392#discussion_r1600616490
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -679,55 +661,6 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
)))
}
- fn parse_array_agg(
- &self,
- array_agg: ArrayAgg,
- input_schema: &DFSchema,
- planner_context: &mut PlannerContext,
- ) -> Result<Expr> {
- // Some dialects have special syntax for array_agg. DataFusion only
supports it like a function.
Review Comment:
Sqlparser now handles this without a special case -- in
https://github.com/sqlparser-rs/sqlparser-rs/pull/1247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
