alamb commented on issue #10534: URL: https://github.com/apache/datafusion/issues/10534#issuecomment-2113211517
@jayzhan211 asks https://github.com/apache/datafusion/issues/10374#issuecomment-2111340945 > > @alamb Do you think we should also rewrite the array operator to function in parser step? It is currently in optimizer step. I think the downside of moving array rewrite in parser step is that if any user expects different array function with the same syntax, then they can't do it since we don't have "user-defined" parser mechanism now. But the benefit is that we can eliminate intermediate binary expression. > > The array operator to function is syntax like `array1 || array2` -> `array_concat`, which is in ArrayFunctionRewriter now, so I'm thinking about whether we should move this to the parser or not. I personally think moving the translation of `array1 || array` --> `array_concat` to the parser is a better idea as it will be more efficient than trying to rewrite an expr after the fact -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
