yyy1000 commented on code in PR #10539: URL: https://github.com/apache/datafusion/pull/10539#discussion_r1602617505
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -2480,6 +2480,399 @@ Select bit_xor(DISTINCT c), arrow_typeof(bit_xor(DISTINCT c)) from t; statement ok drop table t; +################# +# Min_Max Begin # +################# +statement ok Review Comment: I think generally it looks good to me. But could you please add some comments to the sqllogictest? For each unit test, add a comment beginning with `# ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
