kazuyukitanimura commented on code in PR #436:
URL: https://github.com/apache/datafusion-comet/pull/436#discussion_r1602683233
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -1399,7 +1399,7 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
CometConf.COMET_EXEC_ENABLED.key -> "true",
CometConf.COMET_SHUFFLE_ENFORCE_MODE_ENABLED.key -> "true",
CometConf.COMET_EXEC_ALL_OPERATOR_ENABLED.key -> "true",
- "spark.sql.extendedExplainProvider" ->
"org.apache.comet.ExtendedExplainInfo") {
Review Comment:
Correct, it passes with or without this config for Spark 3.x because the
test is disabled by `supportsExtendedExplainInfo` that is `false`.
For Spark 4.0 or any Spark fork that implements the extended info,
`supportsExtendedExplainInfo` returns true. Then it fails with the previous
wrong config name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
