Blizzara commented on code in PR #10531:
URL: https://github.com/apache/datafusion/pull/10531#discussion_r1601979954
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1277,6 +1407,56 @@ pub(crate) fn from_substrait_literal(lit: &Literal) ->
Result<ScalarValue> {
s,
)
}
+ Some(LiteralType::List(l)) => {
Review Comment:
I don't necessarily need these for this PR, so if it's preferrable I'm happy
to split them into separate PRs - I just added them while coding to confirm
that lists and structs inside lists are handled correctly.
Same applies for the ones in `producer.rs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
