alamb commented on code in PR #10444:
URL: https://github.com/apache/datafusion/pull/10444#discussion_r1603886068
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -941,22 +935,65 @@ impl OptimizerRule for PushDownFilter {
None =>
extension_plan.node.inputs().into_iter().cloned().collect(),
};
// extension with new inputs.
+ let child_plan = LogicalPlan::Extension(extension_plan);
let new_extension =
child_plan.with_new_exprs(child_plan.expressions(),
new_children)?;
- match conjunction(keep_predicates) {
+ let new_plan = match conjunction(keep_predicates) {
Some(predicate) => LogicalPlan::Filter(Filter::try_new(
predicate,
Arc::new(new_extension),
)?),
None => new_extension,
- }
+ };
+ Ok(Transformed::yes(new_plan))
}
- _ => return Ok(Transformed::no(plan)),
- };
+ child => {
+ filter.input = Arc::new(child);
+ Ok(Transformed::no(LogicalPlan::Filter(filter)))
+ }
+ }
+ }
+}
+
+/// Creates a new LogicalPlan::Filter node.
+pub fn make_filter(predicate: Expr, input: Arc<LogicalPlan>) ->
Result<LogicalPlan> {
+ Filter::try_new(predicate, input).map(LogicalPlan::Filter)
+}
- Ok(Transformed::yes(new_plan))
+/// Replace the existing child of the single input node with `new_child`.
+///
+/// Starting:
+/// ```text
+/// plan
+/// child
+/// ```
+///
+/// Ending:
+/// ```text
+/// plan
+/// new_child
+/// ```
+fn insert_below(
+ plan: LogicalPlan,
+ new_child: LogicalPlan,
+) -> Result<Transformed<LogicalPlan>> {
Review Comment:
Maybe I should pull it into optimizer/utils 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
