viirya commented on code in PR #1:
URL: 
https://github.com/apache/datafusion-benchmarks/pull/1#discussion_r1605335130


##########
tpch/queries/sf=1/q1.sql:
##########
@@ -0,0 +1,23 @@
+-- SQLBench-H query 1 derived from TPC-H query 1 under the terms of the TPC 
Fair Use Policy.
+-- TPC-H queries are Copyright 1993-2022 Transaction Processing Performance 
Council.

Review Comment:
   Interesting. I used to use TPC-DS or TPC-H benchmarks like 
https://github.com/databricks/spark-sql-perf, and what we have in Comet or 
Spark. I remember we only specify scale during generating the data, and the 
queries are the same (it is not generated).
   
   Maybe it is specified to this tool you use. It is okay for me if the query 
generator considers scale.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to