alamb commented on code in PR #10564:
URL: https://github.com/apache/datafusion/pull/10564#discussion_r1605446551
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -234,7 +234,7 @@ fn create_physical_name(e: &Expr, is_first_expr: bool) ->
Result<String> {
stride: _,
} => {
unreachable!(
- "ListRange should have been rewritten in
OperatorToFunction"
+ "ListRange should have been rewritten in
ArrayFunctionRewriter"
Review Comment:
Actually, now that I think about this I think the issue is that we now
expect that these Exprs should never be present....
I think they can still be created via `Expr::field(name)`...
Will double check / see if I can make a reproduicer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
