viirya commented on code in PR #447:
URL: https://github.com/apache/datafusion-comet/pull/447#discussion_r1605914565
##########
spark/src/test/resources/tpcds-plan-stability/approved-plans-v2_7/q5a/explain.txt:
##########
@@ -72,70 +72,16 @@ TakeOrderedAndProject (137)
: +- * ColumnarToRow (58)
: +- CometFilter (57)
: +- CometScan parquet
spark_catalog.default.web_site (56)
- :- * HashAggregate (100)
- : +- Exchange (99)
- : +- * HashAggregate (98)
- : +- * HashAggregate (97)
- : +- Exchange (96)
- : +- * HashAggregate (95)
- : +- Union (94)
- : :- * HashAggregate (70)
- : : +- ReusedExchange (69)
- : :- * HashAggregate (72)
- : : +- ReusedExchange (71)
- : +- * HashAggregate (93)
- : +- Exchange (92)
- : +- * HashAggregate (91)
- : +- * Project (90)
- : +- * BroadcastHashJoin Inner
BuildRight (89)
- : :- * Project (87)
- : : +- * BroadcastHashJoin
Inner BuildRight (86)
- : : :- * ColumnarToRow (84)
- : : : +- CometUnion (83)
- : : : :- CometProject
(75)
- : : : : +- CometFilter
(74)
- : : : : +- CometScan
parquet spark_catalog.default.web_sales (73)
- : : : +- CometProject
(82)
- : : : +-
CometBroadcastHashJoin (81)
- : : : :-
CometBroadcastExchange (77)
- : : : : +-
CometScan parquet spark_catalog.default.web_returns (76)
- : : : +-
CometProject (80)
- : : : +-
CometFilter (79)
- : : : +-
CometScan parquet spark_catalog.default.web_sales (78)
- : : +- ReusedExchange (85)
- : +- ReusedExchange (88)
- +- * HashAggregate (132)
- +- Exchange (131)
- +- * HashAggregate (130)
- +- * HashAggregate (129)
- +- Exchange (128)
- +- * HashAggregate (127)
- +- Union (126)
- :- * HashAggregate (102)
- : +- ReusedExchange (101)
- :- * HashAggregate (104)
- : +- ReusedExchange (103)
- +- * HashAggregate (125)
- +- Exchange (124)
- +- * HashAggregate (123)
- +- * Project (122)
- +- * BroadcastHashJoin Inner
BuildRight (121)
- :- * Project (119)
- : +- * BroadcastHashJoin
Inner BuildRight (118)
- : :- * ColumnarToRow (116)
- : : +- CometUnion (115)
- : : :- CometProject
(107)
- : : : +- CometFilter
(106)
- : : : +- CometScan
parquet spark_catalog.default.web_sales (105)
- : : +- CometProject
(114)
- : : +-
CometBroadcastHashJoin (113)
- : : :-
CometBroadcastExchange (109)
- : : : +-
CometScan parquet spark_catalog.default.web_returns (108)
- : : +-
CometProject (112)
- : : +-
CometFilter (111)
- : : +-
CometScan parquet spark_catalog.default.web_sales (110)
- : +- ReusedExchange (117)
- +- ReusedExchange (120)
+ :- * HashAggregate (73)
+ : +- Exchange (72)
+ : +- * HashAggregate (71)
+ : +- * HashAggregate (70)
+ : +- ReusedExchange (69)
Review Comment:
After this fix, we get more `ReusedExchange` in tpcds query plans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
