alamb commented on code in PR #10603:
URL: https://github.com/apache/datafusion/pull/10603#discussion_r1608860177
##########
datafusion/sql/src/unparser/plan.rs:
##########
@@ -347,8 +373,33 @@ impl Unparser<'_> {
Ok(())
}
- LogicalPlan::Union(_union) => {
- not_impl_err!("Unsupported operator: {plan:?}")
+ LogicalPlan::Union(union) => {
Review Comment:
I double checked that Union is UNION ALL
https://docs.rs/datafusion/latest/datafusion/logical_expr/struct.Union.html
##########
datafusion/sql/tests/sql_integration.rs:
##########
@@ -4641,6 +4641,14 @@ fn roundtrip_statement() -> Result<()> {
group by "Last Name", p.id
having count_first_name>5 and count_first_name<10
order by count_first_name, "Last Name""#,
+ r#"SELECT j1_string as string FROM j1
Review Comment:
Perhaps we should also add a test (as a follow on PR) for `UNION` (not
`UNION ALL`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
