advancedxy commented on code in PR #455: URL: https://github.com/apache/datafusion-comet/pull/455#discussion_r1609204351
########## docs/spark_expressions_support.md: ########## @@ -0,0 +1,477 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Supported Spark Expressions + +### agg_funcs + - [ ] any + - [ ] any_value + - [ ] approx_count_distinct + - [ ] approx_percentile + - [ ] array_agg + - [ ] avg + - [ ] bit_and + - [ ] bit_or + - [ ] bit_xor + - [ ] bool_and + - [ ] bool_or + - [ ] collect_list + - [ ] collect_set + - [ ] corr + - [ ] count + - [ ] count_if + - [ ] count_min_sketch + - [ ] covar_pop + - [ ] covar_samp + - [ ] every + - [ ] first + - [ ] first_value + - [ ] grouping + - [ ] grouping_id + - [ ] histogram_numeric + - [ ] kurtosis + - [ ] last + - [ ] last_value + - [ ] max + - [ ] max_by + - [ ] mean + - [ ] median + - [ ] min + - [ ] min_by + - [ ] mode + - [ ] percentile + - [ ] percentile_approx + - [ ] regr_avgx + - [ ] regr_avgy + - [ ] regr_count + - [ ] regr_intercept + - [ ] regr_r2 + - [ ] regr_slope + - [ ] regr_sxx + - [ ] regr_sxy + - [ ] regr_syy + - [ ] skewness + - [ ] some + - [ ] std + - [ ] stddev + - [ ] stddev_pop + - [ ] stddev_samp Review Comment: Yeah.. Maybe we need to enable Comet Shuffle to re-run the CometExpressionCoverageSuite. ########## docs/spark_expressions_support.md: ########## @@ -0,0 +1,477 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Supported Spark Expressions + +### agg_funcs + - [ ] any + - [ ] any_value + - [ ] approx_count_distinct + - [ ] approx_percentile + - [ ] array_agg + - [ ] avg + - [ ] bit_and + - [ ] bit_or + - [ ] bit_xor + - [ ] bool_and + - [ ] bool_or + - [ ] collect_list + - [ ] collect_set + - [ ] corr + - [ ] count + - [ ] count_if + - [ ] count_min_sketch + - [ ] covar_pop + - [ ] covar_samp + - [ ] every + - [ ] first + - [ ] first_value + - [ ] grouping + - [ ] grouping_id + - [ ] histogram_numeric + - [ ] kurtosis + - [ ] last + - [ ] last_value + - [ ] max + - [ ] max_by + - [ ] mean + - [ ] median + - [ ] min + - [ ] min_by + - [ ] mode + - [ ] percentile + - [ ] percentile_approx + - [ ] regr_avgx + - [ ] regr_avgy + - [ ] regr_count + - [ ] regr_intercept + - [ ] regr_r2 + - [ ] regr_slope + - [ ] regr_sxx + - [ ] regr_sxy + - [ ] regr_syy + - [ ] skewness + - [ ] some + - [ ] std + - [ ] stddev + - [ ] stddev_pop + - [ ] stddev_samp + - [ ] sum + - [ ] try_avg + - [ ] try_sum + - [ ] var_pop + - [ ] var_samp + - [ ] variance + +### array_funcs + - [ ] array + - [ ] array_append + - [ ] array_compact + - [ ] array_contains + - [ ] array_distinct + - [ ] array_except + - [ ] array_insert + - [ ] array_intersect + - [ ] array_join + - [ ] array_max + - [ ] array_min + - [ ] array_position + - [ ] array_remove + - [ ] array_repeat + - [ ] array_union + - [ ] arrays_overlap + - [ ] arrays_zip + - [ ] flatten + - [x] get + - [ ] sequence + - [ ] shuffle + - [ ] slice + - [ ] sort_array + +### bitwise_funcs + - [x] & + - [x] ^ + - [ ] bit_count + - [ ] bit_get + - [ ] getbit + - [x] shiftright + - [ ] shiftrightunsigned + - [x] | + - [ ] ~ + +### collection_funcs + - [ ] array_size + - [ ] cardinality + - [ ] concat + - [x] reverse + - [ ] size + +### conditional_funcs + - [x] coalesce + - [x] if + - [ ] ifnull + - [ ] nanvl + - [x] nullif + - [ ] nvl Review Comment: hmm, it should be supported? It's essential the same as `coalesce`, which is replaced during analysis phase. Maybe we should file an issue to track this kind of problem. ########## docs/spark_expressions_support.md: ########## @@ -0,0 +1,477 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Supported Spark Expressions + +### agg_funcs + - [ ] any + - [ ] any_value + - [ ] approx_count_distinct + - [ ] approx_percentile + - [ ] array_agg + - [ ] avg + - [ ] bit_and + - [ ] bit_or + - [ ] bit_xor + - [ ] bool_and + - [ ] bool_or + - [ ] collect_list + - [ ] collect_set + - [ ] corr + - [ ] count + - [ ] count_if + - [ ] count_min_sketch + - [ ] covar_pop + - [ ] covar_samp + - [ ] every + - [ ] first + - [ ] first_value + - [ ] grouping + - [ ] grouping_id + - [ ] histogram_numeric + - [ ] kurtosis + - [ ] last + - [ ] last_value + - [ ] max + - [ ] max_by + - [ ] mean + - [ ] median + - [ ] min + - [ ] min_by + - [ ] mode + - [ ] percentile + - [ ] percentile_approx + - [ ] regr_avgx + - [ ] regr_avgy + - [ ] regr_count + - [ ] regr_intercept + - [ ] regr_r2 + - [ ] regr_slope + - [ ] regr_sxx + - [ ] regr_sxy + - [ ] regr_syy + - [ ] skewness + - [ ] some + - [ ] std + - [ ] stddev + - [ ] stddev_pop + - [ ] stddev_samp + - [ ] sum + - [ ] try_avg + - [ ] try_sum + - [ ] var_pop + - [ ] var_samp + - [ ] variance + +### array_funcs + - [ ] array + - [ ] array_append + - [ ] array_compact + - [ ] array_contains + - [ ] array_distinct + - [ ] array_except + - [ ] array_insert + - [ ] array_intersect + - [ ] array_join + - [ ] array_max + - [ ] array_min + - [ ] array_position + - [ ] array_remove + - [ ] array_repeat + - [ ] array_union + - [ ] arrays_overlap + - [ ] arrays_zip + - [ ] flatten + - [x] get + - [ ] sequence + - [ ] shuffle + - [ ] slice + - [ ] sort_array + +### bitwise_funcs + - [x] & + - [x] ^ + - [ ] bit_count + - [ ] bit_get + - [ ] getbit + - [x] shiftright + - [ ] shiftrightunsigned + - [x] | + - [ ] ~ + +### collection_funcs + - [ ] array_size + - [ ] cardinality + - [ ] concat + - [x] reverse + - [ ] size + +### conditional_funcs + - [x] coalesce + - [x] if + - [ ] ifnull + - [ ] nanvl + - [x] nullif + - [ ] nvl + - [x] nvl2 + - [x] when + +### conversion_funcs + - [ ] bigint + - [ ] binary + - [ ] boolean + - [x] cast + - [ ] date + - [ ] decimal + - [ ] double + - [ ] float + - [ ] int + - [ ] smallint + - [ ] string + - [ ] timestamp + - [ ] tinyint + +### csv_funcs + - [ ] from_csv + - [ ] schema_of_csv + - [ ] to_csv + +### datetime_funcs + - [ ] add_months + - [ ] convert_timezone + - [x] curdate + - [x] current_date + - [ ] current_timestamp + - [x] current_timezone + - [ ] date_add + - [ ] date_diff + - [ ] date_format + - [ ] date_from_unix_date + - [x] date_part + - [ ] date_sub + - [ ] date_trunc + - [ ] dateadd + - [ ] datediff + - [x] datepart + - [ ] day + - [ ] dayofmonth + - [ ] dayofweek + - [ ] dayofyear + - [x] extract + - [ ] from_unixtime + - [ ] from_utc_timestamp + - [ ] hour + - [ ] last_day + - [ ] localtimestamp + - [ ] make_date + - [ ] make_dt_interval + - [ ] make_interval + - [ ] make_timestamp + - [ ] make_timestamp_ltz + - [ ] make_timestamp_ntz + - [ ] make_ym_interval + - [ ] minute + - [ ] month + - [ ] months_between + - [ ] next_day + - [ ] now + - [ ] quarter + - [ ] second + - [ ] timestamp_micros + - [ ] timestamp_millis + - [ ] timestamp_seconds + - [x] to_date + - [x] to_timestamp + - [x] to_timestamp_ltz + - [ ] to_timestamp_ntz + - [ ] to_unix_timestamp + - [ ] to_utc_timestamp + - [ ] trunc + - [x] try_to_timestamp + - [ ] unix_date + - [ ] unix_micros + - [ ] unix_millis + - [ ] unix_seconds + - [ ] unix_timestamp + - [ ] weekday + - [ ] weekofyear + - [x] year + +### generator_funcs + - [ ] explode + - [ ] explode_outer + - [ ] inline + - [ ] inline_outer + - [ ] posexplode + - [ ] posexplode_outer + - [ ] stack + +### hash_funcs + - [ ] crc32 + - [ ] hash Review Comment: ~~hash should be supported.~~ Ah, the example hash function passes an array, which haven't been supported in Comet as supported type yet. Maybe supporting nested type could be prioritized after we have fully TPC-H and TPC-DS support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
