peter-toth commented on code in PR #10543:
URL: https://github.com/apache/datafusion/pull/10543#discussion_r1611241009
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -258,6 +259,10 @@ impl CaseExpr {
}
}
+lazy_static! {
Review Comment:
We need to restore the `CaseExpr` in `CaseExpr::with_new_children()` from
the a `children: Vec<Arc<dyn PhysicalExpr>>`. If we don't push anyting for the
2 optional `CaseExpr.expr` and `CaseExpr.else_expr` fields, then I don't think
there is a way to tell if the first element of `children` belongs to the
optional `CaseExpr.expr` or to `CaseExpr.when_then_expr`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
